Don't fail on empty part, just return zero length #1621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinhvh
reviewed
Mar 13, 2017
|
|
||
| if (text == NULL) | ||
| return MAILIMAP_ERROR_FETCH; | ||
| if (text == NULL) { |
Member
There was a problem hiding this comment.
Can you enable that behavior only if outlook server is detected?
added 2 commits
March 22, 2017 12:57
…st zero length (2)
Member
|
Sorry for not getting back to you earlier. This pull request somehow went out of my focus. |
dinhvh
reviewed
Apr 24, 2017
| @@ -1,4 +1,4 @@ | |||
| ## MailCore 2: Introduction ## | |||
| ## MailCore 2: Introduction ## | |||
| bool wholePart, uint32_t offset, uint32_t length, | ||
| Encoding encoding, IMAPProgressCallback * progressCallback, ErrorCode * pError); | ||
| void storeLabels(String * folder, bool identifier_is_uid, IndexSet * identifiers, IMAPStoreFlagsRequestKind kind, Array * labels, ErrorCode * pError); | ||
| int fetch_rfc822(mailimap * session, bool identifier_is_uid, uint32_t identifier, char ** result, size_t * result_len); |
Member
There was a problem hiding this comment.
Why are those part of the change?
|
|
||
| #ifdef __cplusplus | ||
|
|
||
| typedef struct mailimap_fetch_type mailimap_fetch_type; |
Member
There was a problem hiding this comment.
I'd prefer if that data type wasn't public.
bengotow
pushed a commit
to Foundry376/Mailspring-Sync
that referenced
this pull request
Jan 1, 2026
Cherry-pick fix from upstream mailcore2 PR #1621. Outlook.com IMAP server sometimes omits message parts and returns them as zero-length when there is a vCalendar part in the message. Previously this would cause a MAILIMAP_ERROR_FETCH error, failing the entire fetch. This fix: 1. Adds mOutlookServer detection based on hostname 2. When fetching from Outlook and encountering a NULL/empty part, returns zero-length data instead of an error This allows messages with vCalendar attachments to be fetched successfully from Outlook.com accounts. Upstream: MailCore/mailcore2#1621
bengotow
added a commit
to Foundry376/Mailspring-Sync
that referenced
this pull request
Jan 1, 2026
Cherry-pick fix from upstream mailcore2 PR #1621. Outlook.com IMAP server sometimes omits message parts and returns them as zero-length when there is a vCalendar part in the message. Previously this would cause a MAILIMAP_ERROR_FETCH error, failing the entire fetch. This fix: 1. Adds mOutlookServer detection based on hostname 2. When fetching from Outlook and encountering a NULL/empty part, returns zero-length data instead of an error This allows messages with vCalendar attachments to be fetched successfully from Outlook.com accounts. Upstream: MailCore/mailcore2#1621 Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outlook.com IMAP server omits some parts and returns them as zero-length ones if there is vCalendar part in the message.
IMAP dump and message content is in the attachment.
Attachment.zip