Skip to content

Ci: updated how blockscan is built and deployed#250

Draft
Simon-Tl wants to merge 5 commits intoMagickbase:mainfrom
Simon-Tl:docker-compose
Draft

Ci: updated how blockscan is built and deployed#250
Simon-Tl wants to merge 5 commits intoMagickbase:mainfrom
Simon-Tl:docker-compose

Conversation

@Simon-Tl
Copy link

@Simon-Tl Simon-Tl commented Aug 24, 2023

Motivation

  • Modified Dockerfile, docker-compose.yml Redundant variables are removed and automatic mirror building is added It can be used for rapid deployment, reducing the time required for developers to deploy

Changelog

Enhancements

    1. Modify docker-compose to add redundant variables in env to dockerfile
    1. Run dev.env to overwrite variables in dockerfile in real time
    1. Add docker-build workflow for quickly building images and reducing developer deployment time

@Simon-Tl Simon-Tl closed this Aug 24, 2023
@Simon-Tl Simon-Tl reopened this Aug 24, 2023
@Simon-Tl Simon-Tl changed the title Docker compose Ci: updated how blockscan is built and deployed Aug 24, 2023

steps:
- name: Checkout Repository
uses: actions/checkout@v2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider using checkout@v3 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap

context: ./
file: ./docker/Dockerfile
push: true
tags: ghcr.io/magickbase/${{env.IMAGE_NAME}}:latest No newline at end of file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we use github.ref_name as the image tag?

Copy link
Author

@Simon-Tl Simon-Tl Aug 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I want to do so, but blockscan does not have corresponding release process and branch building process at present, can we promote tag construction

Co-authored-by: Flouse <1297478+Flouse@users.noreply.github.com>
Signed-off-by: Simon <96721494+Simon-Tl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants