feat: enforce mandatory allowlist for security#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the security vulnerability where the bot, by default, is open to all Telegram users. This change implements a "secure-by-default" policy as suggested:
telegram.allowlistis now a required configuration. The bot will refuse to start if it's left with the default placeholder value ([-1]).[]), though this is discouraged.README.mdhas been significantly updated with a new Security Concerns section that explains this feature and provides clear instructions for users on how to find their Chat ID.This makes the bot significantly more secure out-of-the-box and protects users from unsolicited messages and potential abuse.
Fixes #6