You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you have a PyPI account, let me know your username and I'll add you as an/the owner of the markdown-icons and push a release to it so people can pip install markdown-icons! 😄
It currently runs in both, this just makes it support Python 2 a bit better, because dict.items() in Python 2 returns a list (could be big), and dict.items() in Python 3 returns an iterator. To get an iterator in Python 2, you could call dict.iteritems(), but that method doesn't exist in Python 3.
So, in order to return an iterator in both Python 2 and 3, six has an iteritems() function, which is what we use here.
It's a two line change (including the import six line), and as long as it's syntactically correct (it is), it will run in both Python 2 and 3. But, since it's only a performance enhancement to code that probably won't ever be a bottleneck, this patch very well might be premature optimization. I just like to do things The Right Way.
Cheers! 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.