Skip to content

Some improves on the class API#1

Open
13dev wants to merge 4 commits intoMachiavelSST:masterfrom
13dev:master
Open

Some improves on the class API#1
13dev wants to merge 4 commits intoMachiavelSST:masterfrom
13dev:master

Conversation

@13dev
Copy link

@13dev 13dev commented Sep 14, 2020 •
edited
Loading

This pr improve some readability of the code, remove the try catch, add namespace

Some ideas:

  • Add composer.json with require dependencies
  • Add constants to various methods types
  • make a list with the current attacks, and the remaing time
  • Update to PHP 7.0 >=
  • Add type params and properties

@13dev
refactor(Api):
19ecf63 
- Fix spaces
- Remove catch block
- Improve var names
- Add php file
example
- adopt camelcaseStyle
- Add namespace
@13dev
refactor(Api):
5de62e0 
- Add php file example
@13dev
Edit docs
21fdfdf
@13dev
Fix name of the class
fd6cb14
@Ma1572
Copy link

Ma1572 commented Oct 13, 2021

Thank

1 similar comment
@Ma1572
Copy link

Ma1572 commented Nov 8, 2021

Thank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@13dev @Ma1572