Add missing dependency to src/meson.build so KMSCON builds successfully#4
Open
sidstuff wants to merge 1 commit intoMacSlow:add-kmscon.conf-manpagefrom
Open
Add missing dependency to src/meson.build so KMSCON builds successfully#4sidstuff wants to merge 1 commit intoMacSlow:add-kmscon.conf-manpagefrom
src/meson.build so KMSCON builds successfully#4sidstuff wants to merge 1 commit intoMacSlow:add-kmscon.conf-manpagefrom
Conversation
…--cflags dbus-1)` is used in the `cc` command when building
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I'd like to submit a small fix as currently it seems the repo does not build successfully (tested on Ubuntu Server 25.04 with all required packages installed).
I ran
meson buillddir/followed bysudo meson install -C builddir/, the latter of which failed, printing:The error shows that the required
-Iflags fordbus-1(given bypkg-config --cflags dbus-1) were not included in thecccommand—but those forlibdrmwere.So searching the build files for where
libdrmwas included as a dependency butdbus-1wasn't, it seems to beuterm_depinsrc/meson.build.And indeed, adding
dbus_depstouterm_depmakes KMSCON build successfully; see the new output ofsudo meson install -C builddir/.Fixes #1