Support for UnifiedUI (UUI) 2.2.1 - Continued (Workshop ID 2966990700) #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he UUI Register function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added UnifiedUI (UUI) 2.2.1 - Continued (WorkshopID #2966990700) to the UUI Register method. Please review the line changed.
UNTESTED IN-GAME - PLAN TO TEST 2023/05/26
PLAN TO RELEASE UPDATED UnifiedUI (UUI) 2.2.1 - Continued (compiled for resorts free update) 2023/05/26 (will leave unlisted for now and marked as beta for now)
(Additional details - skip if you're short on time)
n.b.: Reading the method makes me wonder if it should check the namespace OR ID if both are provided; it skips the namespace check if it the ID parameter array is provided. This does prevent possible duplicate assembly issues (people should not be installing duplicate versions of the mod) but I'm not necessarily sure that is the most optimal from a maintenance standpoint; i.e., if I release a beta version (after ID=2966990700 is promoted to stable) or if someone else releases some other UUI after I go on.
Regardless, with CS:2 supposedly releasing later this year, I suppose it's a non-issue, but maybe something to think about for pub/sub models in CS:2 modding.
From my professional experience the namespace was the general go-to as we didn't need to update it per environment -- i.e., production, UAT, staging, QA, etc -- and if we needed to, we added support to limit it at configuration time in a settings file or administrative configuration panel, not compile time.