Skip to content

Node gyp#6

Merged
MXASoundNDEv merged 3 commits intomainfrom
Node-gyp
Sep 23, 2025
Merged

Node gyp#6
MXASoundNDEv merged 3 commits intomainfrom
Node-gyp

Conversation

@MXASoundNDEv
Copy link
Copy Markdown
Owner

📋 Description

Fix missing file

🔄 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

🧪 How Has This Been Tested?

  • Unit tests pass

Test Configuration:

  • Node.js version:22.17.1
  • Operating System:Win11

📋 Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Maxime Knecht added 3 commits September 22, 2025 16:35
…E, intégrant des sections sur l'importation, le cycle de vie, les méthodes et les bonnes pratiques.
Copilot AI review requested due to automatic review settings September 23, 2025 09:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a missing file issue by adding the binding.gyp file to the package distribution and updating the version to 1.2.0. The change ensures that the node-gyp build configuration file is included when the package is published, which is essential for native module compilation.

  • Added binding.gyp to the package files list in package.json
  • Bumped version from 1.1.6 to 1.2.0
  • Added comprehensive API documentation to README files

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Added binding.gyp to files array and version bump to 1.2.0
README.md Added extensive French API documentation for SoemMaster
README.en.md Added complete English API documentation and examples

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@MXASoundNDEv MXASoundNDEv merged commit 432208a into main Sep 23, 2025
1 check passed
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants