Fix incorrect hvac_action when valveOpening = 0#253
Open
dinf60 wants to merge 1 commit intoMTrab:masterfrom
Open
Fix incorrect hvac_action when valveOpening = 0#253dinf60 wants to merge 1 commit intoMTrab:masterfrom
dinf60 wants to merge 1 commit intoMTrab:masterfrom
Conversation
Author
|
I forgot to mention that this PR will close issue #147. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
‒ Ally-komponenten bruger kun feltet work_state til at bestemme
hvac_action.
‒ Icon2 (fw ≥ 1.6) lader ofte work_state stå på Heat, selv om
ventilen er lukket (= ingen varme).
‒ Controlleren sender samtidig et mere pålideligt felt:
• output_status (True = ventil åben) eller
• valveOpening (0 % = ventil lukket)
Løsning
Tjek først output_status / valveOpening; fald tilbage til
work_state, hvis de ikke findes.