Skip to content

use array spread for htmlcollection foreach #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ffont merged 2 commits into from
Feb 18, 2026
+6 −6
Merged

use array spread for htmlcollection foreach #2064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8239945
use array spread on document.getElementsByClassName
alastair Feb 18, 2026
210ee84
use array spread instead of Array.from for consistency
alastair Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions freesound/static/bw-frontend/src/components/select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ function makeSelect(container) {
}
} else {
currentKeysPressed += evt.key;
Array.from(ulElement.children).every(liElement => {
[...ulElement.children].every(liElement => {
if (
liElement.innerHTML
.toLowerCase()
Expand Down Expand Up @@ -176,7 +176,7 @@ function makeSelect(container) {
}

function removeActiveClassFromAllLiElements(ulElement) {
Array.from(ulElement.children).forEach(liElement => {
[...ulElement.children].forEach(liElement => {
liElement.classList.remove('active');
});
}
Expand All @@ -189,7 +189,7 @@ function makeSelect(container) {
if (liElement === undefined) {
return ulElement.children[ulElement.children.length - 1];
}
const index = Array.from(ulElement.children).indexOf(liElement);
const index = [...ulElement.children].indexOf(liElement);
if (index > 0) {
return ulElement.children[index - 1];
} else {
Expand All @@ -201,8 +201,8 @@ function makeSelect(container) {
if (liElement === undefined) {
return ulElement.children[0];
}
const index = Array.from(ulElement.children).indexOf(liElement);
if (Array.from(ulElement.children).length > index + 1) {
const index = [...ulElement.children].indexOf(liElement);
if ([...ulElement.children].length > index + 1) {
return ulElement.children[index + 1];
} else {
return ulElement.children[index];
Expand Down
2 changes: 1 addition & 1 deletion freesound/static/bw-frontend/src/pages/messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import debounce from 'lodash.debounce';
const checkboxSelectAllElement = document.getElementById('selectAll');
const messageCheckboxes = [...document.getElementsByClassName('message-checkbox')];
const actionsMenu = document.getElementsByClassName('actions-menu')[0];
const messageActionButtons = document.getElementsByClassName('message-action');
const messageActionButtons = [...document.getElementsByClassName('message-action')];
const LastMessageElement = document.getElementById('message-last');
const usernameToFormField = document.getElementById('username-to-field');

Expand Down