Changes to enable building of MRtrix3 extensions #2939
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daljit46
force-pushed
the
external_project_changes
branch
from
b2dd8e1 to
deaa91f
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
daljit46
force-pushed
the
external_project_changes
branch
2 times, most recently
from
57d7413 to
e967339
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
daljit46
force-pushed
the
external_project_changes
branch
from
e967339 to
da8b44b
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
To handle the installation of external Python commands, a new option for MakePythonExecutable is added to set a different location for the library files.
daljit46
force-pushed
the
external_project_changes
branch
from
562aeea to
bc389cd
Compare
Lestropie
force-pushed
the
external_project_changes
branch
from
62bd341 to
c988a4d
Compare
Lestropie
force-pushed
the
dev
branch
2 times, most recently
from
70031c3 to
6bf4cec
Compare
Lestropie
force-pushed
the
external_project_changes
branch
from
c988a4d to
62bd341
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will contain a bunch of changes related to #2901. The aim is to enable building MRtrix3 as a subproject of another CMake project. It provides the ability to set a
MRTRIX_SUBPROJECT_INSTALL_PREFIXvariable to choose an installation prefix where MRtrix3 will be installed (to enable the idea that when MRtrix3 is built as a subproject, its installation files will reside inCMAKE_INSTALL_PREFIX/mrtrix3). Additionally, a newEXTERNAL_PROJECT_COMMANDoption is added toMakePythonExecutable.cmaketo appropriately set the relative location of MRtrix3 python library sources.Also supersedes #2909.