-
Notifications
You must be signed in to change notification settings - Fork 3
Migrate backwards from jazzy to humble for Jetson #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use pip to install python packages
|
@RCoder01 This is ready |
| msg.theta.x = data->theta[0]; | ||
| msg.theta.y = data->theta[1]; | ||
| msg.theta.z = data->theta[2]; | ||
| pub_ins->publish(msg); }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a standard autoformatter for C++? Doesn't have to be automated in any way because of how (hopefully) infrequently C++ code will change, but consistency would be nice (I personally hate { on newlines)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also personally hate how the auto formatter i'm using formats it but that is autoformatted, we can use a different one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the ROS 2 distribution from Jazzy back to Humble to support Jetson hardware compatibility. The changes primarily involve updating Docker configuration, removing external Inertial Sense workspace in favor of an integrated SDK submodule, and adding a new IMU HAL package.
- Downgraded ROS 2 distribution from Jazzy to Humble across all configuration files
- Integrated inertial-sense-sdk as a submodule directly into mrobosub_hal_imu package
- Added new mrobosub_hal_imu package for IMU hardware abstraction
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Dockerfile | Updated base image and package references from jazzy to humble; removed separate inertial_sense_ws; changed from pipx to pip3 for Python packages |
| .bash_aliases | Made MYPYPATH dynamic to support different Python versions across ROS distributions |
| .vscode/c_cpp_properties.json | Updated include paths from noetic to humble |
| .vscode/settings.json | Added file associations for HTML, xacro, and chrono |
| .gitmodules | Moved inertial-sense-sdk submodule from mrobosub_localization to mrobosub_hal_imu |
| mrobosub_hal_imu/CMakeLists.txt | Build configuration for new IMU node |
| mrobosub_hal_imu/package.xml | Package metadata and dependencies |
| mrobosub_hal_imu/src/imu_node.cpp | IMU node implementation using inertial-sense-sdk |
| mrobosub_hal_imu/LICENSE | BSD 2.0 license file |
| mrobosub_hal_imu/inertial-sense-sdk | Submodule commit reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This is probably a ros migration thing and not a humble backport thing but getting the error |
RCoder01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's issues with this branch running on the jetson, but I don't think those were caused by this PR, so I'd rather merge this now and open later PRs to fix those issues
No description provided.