Skip to content

Conversation

@HenryLeC
Copy link
Member

@HenryLeC HenryLeC commented Oct 8, 2025

No description provided.

@HenryLeC HenryLeC requested a review from RCoder01 October 8, 2025 01:08
@HenryLeC HenryLeC marked this pull request as ready for review October 8, 2025 18:12
@HenryLeC
Copy link
Member Author

HenryLeC commented Oct 8, 2025

@RCoder01 This is ready

msg.theta.x = data->theta[0];
msg.theta.y = data->theta[1];
msg.theta.z = data->theta[2];
pub_ins->publish(msg); });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a standard autoformatter for C++? Doesn't have to be automated in any way because of how (hopefully) infrequently C++ code will change, but consistency would be nice (I personally hate { on newlines)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also personally hate how the auto formatter i'm using formats it but that is autoformatted, we can use a different one

@RCoder01 RCoder01 requested a review from Copilot October 21, 2025 23:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the ROS 2 distribution from Jazzy back to Humble to support Jetson hardware compatibility. The changes primarily involve updating Docker configuration, removing external Inertial Sense workspace in favor of an integrated SDK submodule, and adding a new IMU HAL package.

  • Downgraded ROS 2 distribution from Jazzy to Humble across all configuration files
  • Integrated inertial-sense-sdk as a submodule directly into mrobosub_hal_imu package
  • Added new mrobosub_hal_imu package for IMU hardware abstraction

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
Dockerfile Updated base image and package references from jazzy to humble; removed separate inertial_sense_ws; changed from pipx to pip3 for Python packages
.bash_aliases Made MYPYPATH dynamic to support different Python versions across ROS distributions
.vscode/c_cpp_properties.json Updated include paths from noetic to humble
.vscode/settings.json Added file associations for HTML, xacro, and chrono
.gitmodules Moved inertial-sense-sdk submodule from mrobosub_localization to mrobosub_hal_imu
mrobosub_hal_imu/CMakeLists.txt Build configuration for new IMU node
mrobosub_hal_imu/package.xml Package metadata and dependencies
mrobosub_hal_imu/src/imu_node.cpp IMU node implementation using inertial-sense-sdk
mrobosub_hal_imu/LICENSE BSD 2.0 license file
mrobosub_hal_imu/inertial-sense-sdk Submodule commit reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

HenryLeC and others added 3 commits October 21, 2025 19:15
@HenryLeC HenryLeC requested a review from Copilot October 22, 2025 00:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@HenryLeC HenryLeC requested a review from RCoder01 October 22, 2025 14:43
@RCoder01
Copy link
Member

RCoder01 commented Oct 26, 2025

This is probably a ros migration thing and not a humble backport thing but getting the error caught exception in launch (see debug for traceback): "package 'inertial_sense_ros2' not found, searching [...] when running this on the Jetson, will debug at a later date

RCoder01
RCoder01 previously approved these changes Oct 27, 2025
Copy link
Member

@RCoder01 RCoder01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's issues with this branch running on the jetson, but I don't think those were caused by this PR, so I'd rather merge this now and open later PRs to fix those issues

@HenryLeC HenryLeC merged commit 00c3523 into devel Oct 29, 2025
2 checks passed
@RCoder01 RCoder01 deleted the ros2_humble branch November 18, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants