Fix Docker workflow: run only on master push, update checkout to v6#45
Merged
tepickering merged 1 commit intomasterfrom Feb 23, 2026
Merged
Fix Docker workflow: run only on master push, update checkout to v6#45tepickering merged 1 commit intomasterfrom
tepickering merged 1 commit intomasterfrom
Conversation
- Scope workflow trigger to push on master only (not pull_request). Secrets are unavailable in PR contexts so the publish step was always failing on PRs. - Update actions/checkout from v4 to v6 (supersedes PR #41). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Docker publish workflow runs on both
pushandpull_requestevents. GitHub doesn't pass repository secrets to PR workflow runs (security restriction), so theDOCKER_USERNAME/DOCKER_PASSWORDsecrets are always empty on PRs, causing every PR check to fail with:Fix
pushonmasteronly — Docker image publishing only makes sense when code lands on the default branch, not on every PRactions/checkoutfromv4tov6(supersedes dependabot PR Bump actions/checkout from 4 to 6 #41, which can be closed)