Skip to content

BUGFIX: Initialize isolist for ellipse fitting#56

Merged
tepickering merged 1 commit intomainfrom
fix_isolist
Oct 24, 2025
Merged

BUGFIX: Initialize isolist for ellipse fitting#56
tepickering merged 1 commit intomainfrom
fix_isolist

Conversation

@tepickering
Copy link
Copy Markdown
Collaborator

when the ellipse fitting failed, isolist wasn't initialized which caused an uncaught exception:

"/mmt/condaforge/envs/mmtwfs/lib/python3.13/site-packages/mmtwfs/wfs.py", line 1304, in measure_slopes vlt_seeing, raw_vlt_seeing = self.vlt_seeing( ~~~~~~~~~~~~~~~^ slope_results["coadded_spot"], mode=mode, airmass=airmass ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ) ^ File "/mmt/condaforge/envs/mmtwfs/lib/python3.13/site-packages/mmtwfs/wfs.py", line 1045, in vlt_seeing if len(isolist) > 0: ^^^^^^^ UnboundLocalError: cannot access local variable 'isolist' where it is not associated with a value

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.00%. Comparing base (b466034) to head (5da5271).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   85.00%   85.00%           
=======================================
  Files          10       10           
  Lines        2327     2328    +1     
=======================================
+ Hits         1978     1979    +1     
  Misses        349      349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tepickering tepickering merged commit bff975a into main Oct 24, 2025
8 checks passed
@tepickering tepickering deleted the fix_isolist branch October 24, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant