Update f/9 effective wavelength; add benchmarking to tests#54
Merged
tepickering merged 1 commit intomainfrom Apr 21, 2025
Merged
Update f/9 effective wavelength; add benchmarking to tests#54tepickering merged 1 commit intomainfrom
tepickering merged 1 commit intomainfrom
Conversation
…filter is still installed. thought it had been removed...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage 85.00% 85.00%
=======================================
Files 10 10
Lines 2327 2327
=======================================
Hits 1978 1978
Misses 349 349 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The f/9 WFS was visually verified to still have its RG610 filter installed. It was thought that this was removed when the original apogee camera was replaced with the current SBIG one in 2016. It turns out that the filter is integrated with the WFS optics themselves behind the collimating lens.
This PR also adds benchmarking to the tests that run a full WFS analysis. This will help track performance impacts of changes in the code and changes in dependencies.