Merged
Conversation
…python 3.9; notebook updates
…lot which isn't working for some internal reason. not comparing quantities correctly somehow
…cific; switch to use our own make_spot_mask; switch axes to ax where needed
…ithin github actions
…lib decorator; force plots to close when test is done; ignore warning from pcolormesh
…o fix numpy dependency
…ulations; mmirs an empirical measurement by b. mcleod.
…ons to include 3.13
…ir S-H systems; propagate coadded spot image so it can be accessed and saved
… spot fits images
…llipse fitting to deconvolved spots and use semi-minor axes as the radial profile for the vlt method of calculating the seeing
…ophote fitting fails and fall back to radial profile
…ug in radial profile; update some doc strings
disable linkcheck in CI
…hanging in certain environments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work started life as work to deploy the wfs analysis interface into a docker container. However, that fell by the wayside and this branch ended up just collecting all updates and fixes. It's well past time to get all of this stuff synced into
main.The most impactful change was to fix a configuration error in MMIRS. The wrong tilt factor was configured in the previous
shwfssoftware and carried over to here. The value has been corrected based on empirical measurements with the MMIRS WFS.Lots of other little config and testing updates. Now only supporting python >= 3.10 and using only 3.12 in CI. There is a significant performance improvement with python >= 3.11.