Camera backside problem solved and visualizing resolution control added#4
Open
Lee-Jun-Hyuk-37 wants to merge 12 commits intoMM4SPA:mainfrom
Open
Camera backside problem solved and visualizing resolution control added#4Lee-Jun-Hyuk-37 wants to merge 12 commits intoMM4SPA:mainfrom
Lee-Jun-Hyuk-37 wants to merge 12 commits intoMM4SPA:mainfrom
Conversation
jtheiner
requested changes
Apr 20, 2023
Contributor
jtheiner
left a comment
There was a problem hiding this comment.
Dear Lee Jun,
thanks for your contributions, in particular the visualization bug.
Before accepting the merge request, please revert the changes in the README.md.
Author
|
I've reverted the changes in the README.md and opened a new pull request. Please review the new pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear maintainer,
Thank you so much for creating a very useful project.
I have solved one problem and added one feature.
When the vertex of the field went to the backside of the camera, it would look like this.


However, after I fixed the problem, it looks like below, just like we expected.


Followings are the examples for the options.
Let's say shape of the raw input image is (1080, 1920), and we resample the image as shape (256, 455) for input to the model.
raw_shape = (1080, 1920)
resampled_shape = (256, 455)
we can use the options as below
I appreciate your work, and I hope my pull request helps for you.
Sincerely,
Lee Jun Hyuk