Updates to issue purge requests to CDN #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Particularly for saving shake and profile images. These have long TTLs like other assets served via CDN, but unlike post images, they can be updated and so have to be purged when they are updated. Note that we don't really have a size limitation for uploaded profile, shake images. They are forcibly resized to 200x200 (or left alone if smaller than this). The site places no restriction on the resulting image size, since a 200x200 JPG should be pretty small. Fixes #450 #447 #345 maybe others
Contributor
|
Yay thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Particularly for saving shake and profile images. These have long TTLs like other assets served via CDN, but unlike post images, they can be updated and so have to be purged when they are updated.
Note that we don't really have a size limitation for uploaded profile, shake images. They are forcibly resized to 200x200 (or left alone if smaller than this). The site places no restriction on the resulting image size, since a 200x200 JPG should be pretty small.
Fixes #450 #447 #345 maybe others