Merged
Conversation
…odule; comments and style
…upled, and can be used in testLIME. also, some fixes in CSSfault
… simpleCSSFaultScenario
…E to two mode scenario
…ing, along with results
MartinAstro
approved these changes
May 16, 2025
Collaborator
MartinAstro
left a comment
There was a problem hiding this comment.
Not going to nitpick right now, but in general the commits are too long and should be more atomic. If your creating a script, the break your commits down into the respective sections of that script. If you are adding new funcitonality, then add the functionality in one commit, and deploy it in a seperate commit, etc. In current form, it's had to inspect all of the things that changed and decide if the changes are what the commit message says they are.
Approving for now just to get it in, but moving forward I recommend adopting a more granular, atomic commit style. Good first go at it though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request creates individual fault injection classes for reaction wheel, coarse sun sensor, and thruster faults. Each class is implemented as a Basilisk module, and can therefore be automated within simulation as any other Basilisk module.
The reaction wheel faults are similar to loss of effectiveness: either max torque is decreased, or increased friction is introduced. The coarse sun sensor faults utilize the built in fault statuses in Basilisk - several stuck points, turning completely off, or random spikes. The thruster faults are relatively simple - at random times, the a thruster turns on at max thrust for a very short interval.
In addition, simple one-dimensional scenarios are created to test and demonstrate each of these faults; the detection of these faults is also considered in testing scripts for LIME and SHAP on Random Forest.
Note: the commits, since many of them were made before my last pull request, are still messy. I apologize for that; the last three commits should be slightly better.