Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for error-based metrics (like RMSE) where lower scores indicate better performance, complementing the existing support for metrics where higher scores are better (like accuracy or F1). The implementation introduces a maximize parameter that, when set to False, internally negates the scores before computing win/tie/loss comparisons.
Changes:
- Added
maximizeboolean parameter toPyBBTclass with default value ofTrue - Modified
_construct_win_tableto negate scores whenmaximize=False - Added test cases verifying correct behavior for both maximize modes
- Updated README documentation with usage example for error-based metrics
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| bbttest/bbt/py_bbt.py | Added maximize parameter to PyBBT class constructor and docstring; parameter is passed to _construct_win_table during fitting |
| bbttest/bbt/alg.py | Modified _construct_win_table to accept maximize parameter and negate algorithm scores when maximize=False; added warning for unnamed columns; changed from set to list for algorithm names |
| tests/bbt/test_alg.py | Added parametrized test cases for _construct_win_table with maximize=True and maximize=False; added test for unnamed column warning |
| README.md | Added new section documenting how to use the maximize parameter for error-based metrics |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.