Conversation
Member
Thematiq
commented
Feb 2, 2026
- Unit tests for PyBBT class
- Regression tests based on the recent article
- Unit tests for PyBBT class - Regression tests based on the recent article
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 16 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (3)
bbttest/bbt/py_bbt.py:234
posterior_table()now acceptscolumns: Iterable[...], butcolumnsis iterated in the validation loop and then used again inout_table[["pair", *columns]]. If a caller passes a one-shot iterable (e.g., a generator), it will be exhausted and the returned DataFrame will omit requested columns. Convertcolumnsto a list once near the top of the method before iterating over it multiple times.
bbttest/bbt/py_bbt.py:290rope_comparison_control_table()currently always appendsrow["left_model"]into the result buckets. However_get_pwin(..., control=...)emits comparisons in both directions (e.g.control > otherfor models ranked below the control; see bbttest/bbt/alg.py:217-222), soleft_modelcan be the control itself. In that case this method will incorrectly classify the control as “better/equivalent/unknown/worse” instead of classifying the other model. Userow["left_model"] == control_modelto decide whether to bucketright_modelorleft_model(and base the decision on the raw interpretation symbol rather than string-matching).
bbttest/bbt/py_bbt.py:255- The
rope_comparison_control_table()docstring’sArgs:section doesn’t match the function signature (it refers tomodelandropes, but the parameters arerope_values,control_model, etc.). Please update the docstring argument names/descriptions so generated docs and IDE help are accurate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
81300f4 to
ac86e0f
Compare
ac86e0f to
37da4ab
Compare
Thematiq
added a commit
that referenced
this pull request
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.