Skip to content

Conversation

@ghukill
Copy link
Contributor

@ghukill ghukill commented Jan 22, 2026

Purpose and background context

Why these changes are being introduced:

There are some breaking changes in pandas 3.x that will require some modifications to how we register dataframes in DuckDB contexts.

How this addresses that need:

In the short term, pin to pandas 2.x for this library.

How can a reviewer manually see the effects of these changes?

Confirmed that a previously unsuccessful run of timdex-embeddings which was building the TDA library pre this pandas<3.0 pinning, is now running successfully.

Includes new or updated dependencies?

YES:

Changes expectations for external applications?

YES: Applications that use this library will be restricted to pandas 2.x until the pin is removed.

What are the relevant tickets?

Code review

  • Code review best practices are documented here and you are encouraged to have a constructive dialogue with your reviewers about their preferences and expectations.

Why these changes are being introduced:

There are some breaking changes in pandas 3.x that will require some
modifications to how we register dataframes in DuckDB contexts.

How this addresses that need:

In the short term, pin to pandas 2.x for this library.

Side effects of this change:
* Applications that use this library will be restricted to
pandas 2.x until the pin is removed.

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/USE-342
  * discovered while installing for timdex-embeddings
@coveralls
Copy link

Pull Request Test Coverage Report for Build 21264452760

Details

  • 16 of 17 (94.12%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.351%

Changes Missing Coverage Covered Lines Changed/Added Lines %
timdex_dataset_api/utils.py 3 4 75.0%
Totals Coverage Status
Change from base Build 20437792958: 0.0%
Covered Lines: 702
Relevant Lines: 752

💛 - Coveralls

@ghukill ghukill marked this pull request as ready for review January 22, 2026 21:01
@ghukill ghukill requested a review from a team as a code owner January 22, 2026 21:01
@ghukill ghukill merged commit 4cf98a4 into main Jan 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants