Skip to content

Conversation

@jonavellecuerdo
Copy link
Contributor

Purpose and background context

This round of maintenance includes the following updates:

  • Update docs; move content from README into docs/
  • Clean up Makefile
    • As requested by @ghukill 's, the script harvester-dockerized was removed from Pipfile in favor of consolidating all docker commands within the Makefile
  • Update dependencies
  • Update PR template

How can a reviewer manually see the effects of these changes?

Unit tests and linting pass.

Includes new or updated dependencies?

YES - make update was run.

Changes expectations for external applications?

NO

What are the relevant tickets?

Code review

  • Code review best practices are documented here and you are encouraged to have a constructive dialogue with your reviewers about their preferences and expectations.

@jonavellecuerdo jonavellecuerdo marked this pull request as ready for review October 21, 2025 13:32
@jonavellecuerdo jonavellecuerdo requested a review from a team October 21, 2025 13:42
@ghukill ghukill self-assigned this Oct 21, 2025
Copy link
Contributor

@ghukill ghukill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to run the following successfully:

make docker-build
make run-harvest-local

I did a read through of the updated README and reorganized docs, all looks great.

All in all, great maintenance updates.

@jonavellecuerdo jonavellecuerdo merged commit d186380 into main Oct 22, 2025
4 checks passed
@jonavellecuerdo jonavellecuerdo deleted the IN-1524-maintenance branch October 22, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants