Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an API configuration issue by updating the base URL for API calls to use an environment variable, allowing for more flexible endpoints during development and production. Key changes include:
- Changing the base URL in transactionService.ts to use an environment variable with a fallback.
- Changing the base URL in authService.ts similarly.
- Updating environment example file and minor whitespace updates in App.tsx.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/services/transactionService.ts | Updated baseUrl to use environment variable and fallback. |
| src/services/authService.ts | Updated baseUrl to use environment variable and fallback. |
| src/App.tsx | Added trailing newline. |
| .env.example | Added environment variable definitions. |
|
|
||
| const baseUrl = | ||
| "https://personal-finance-tracker-production.up.railway.app/api/v1/transactions"; | ||
| const baseUrl = `${import.meta.env.VITE_API_URL || "http://localhost:3000"}/api/v1/transactions`; |
There was a problem hiding this comment.
Consider extracting the API base URL configuration into a shared module to avoid duplication with other services.
| import axios from "axios"; | ||
| const baseUrl = | ||
| "https://personal-finance-tracker-production.up.railway.app/api/v1/auth"; | ||
| const baseUrl = `${import.meta.env.VITE_API_URL || "http://localhost:3000"}/api/v1/auth`; |
There was a problem hiding this comment.
Consider extracting the API base URL configuration into a shared module to reduce duplication and ease maintenance across different services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an API configuration issue by updating the base URL for API calls to use an environment variable, allowing for more flexible endpoints during development and production. Key changes include: