Add S4 CuddManager constructor and C++ wrapper with finalizer#3
Draft
Add S4 CuddManager constructor and C++ wrapper with finalizer#3
CuddManager constructor and C++ wrapper with finalizer#3Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3 +/- ##
==========================================
- Coverage 93.06% 89.24% -3.82%
==========================================
Files 8 15 +7
Lines 403 1458 +1055
==========================================
+ Hits 375 1301 +926
- Misses 28 157 +129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Expose Cudd ADD constructors to R * Add ZDD bindings and operators * Refine diagram APIs and tests * Expose EPD minterm output wrappers * Expose diagram print helpers * Add snapshot tests for diagram output * Add BDD debug output helper * Add BDD DOT dump helper * Add manager controls for cache and verbosity * Expand Cudd manager test coverage * Track manager ownership for CUDD objects * Silence lintr object length warnings * Resolve native symbols before calling * Use native symbols directly in .Call * Bind native symbols without onLoad * Force symbol usage in registration
* Add BDD truth table helper * Remove native symbol delayed assignments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cuddmanager so R code can construct and manage a manager instance without leaking C++ memory.new_cudd_manager.Cuddinstance.methodsnamespace and to follow R naming conventions for constructors.Description
src/cudd_manager.cppwhich implementsc_cudd_new()that allocates aCuddobject, returns an external pointer, and registers a finalizer that deletes theCuddinstance.c_cudd_new()insrc/rcudd.hand registered it insrc/register.cpp(added thec_cudd_newentry toR_registerRoutines).R/cudd_manager.Rthat defines the S4 classCuddManager, the constructorCuddManager()which calls.Call("c_cudd_new"), and ashowmethod, and qualified S4 operations withmethods::instead of importing the namespace.Imports: methodstoDESCRIPTION, exportingCuddManagerinNAMESPACE, and refreshing generated man files (man/CuddManager-class.Rdandman/CuddManager.Rd).Testing
roxygen2::roxygenise()to refresh documentation after the API/name changes, which was executed after installingroxygen2.R CMD build .which producedRcudd_0.0.0.9999.tar.gz.R CMD check --no-manual Rcudd_0.0.0.9999.tar.gzand the check completed successfully withStatus: OK.Codex Task