Skip to content

Node update and minor cleanup#1

Open
marohrdanz wants to merge 3 commits intomainfrom
mary-dev
Open

Node update and minor cleanup#1
marohrdanz wants to merge 3 commits intomainfrom
mary-dev

Conversation

@marohrdanz
Copy link
Collaborator

@marohrdanz marohrdanz commented Mar 20, 2026

This PR is to address security vulnerabilities in Node: https://www.tenable.com/plugins/nessus/282656.

Node 22.x has long-term support into April 2027, so I kept the major version at 22.

Some minor cleanup was also performed

Summary by CodeRabbit

  • Documentation

    • Updated Docker environment setup documentation to include an important prerequisite step that creates the required xpedite-net Docker network before building and launching application containers.
  • Chores

    • Upgraded the Node.js base image to a pinned version for enhanced build consistency and reproducibility.
  • Bug Fixes

    • Fixed spelling error in system logging output.

This step is required for the existing docker-compose file.
The `report` object doesn't have a `name` key (see schema.js), so
changed to `reportfile_name`. Added study name to log for additional
clarity.

Also fixed typo in report.js log message.
Updating because of flagged security vulnerabilities:
https://www.tenable.com/plugins/nessus/282656
@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

📝 Walkthrough

Walkthrough

Updated Docker setup documentation to include network creation, pinned Node.js base image version with digest hash, and adjusted logging statements in report generation and saving functions to reference different report object fields.

Changes

Cohort / File(s) Summary
Documentation & Configuration
README.md
Added docker network create xpedite-net command to Docker startup instructions.
Base Image Update
backend/Dockerfile
Pinned node-base stage to node:22.22.0-slim with specific digest instead of node:22.4.1-bookworm-slim.
Logging Changes
backend/app/index.js, backend/app/report.js
Updated log statements: in index.js, changed from logging req.user.user_name and report.name to logging report.generated_by_user, report.reportfile_name, and req.body.studyName; in report.js, fixed typo in log message from "databse" to "database".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A network for containers to play,
A Node version pinned for the day,
Logs now speak of fields anew,
Database spelled right—hoorah, we flew! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Node update and minor cleanup' accurately reflects the main changes: updating Node.js version and addressing minor corrections in logging and documentation.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mary-dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@marohrdanz
Copy link
Collaborator Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@marohrdanz marohrdanz marked this pull request as ready for review March 20, 2026 21:06
Copy link
Member

@ChrisWakefield ChrisWakefield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear what purpose xpedite-net serves, but we can leave it as is. It was only the comment in the README that got me to notice it.
I've looked over all of these changes and this should move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants