Merged
Conversation
For reference, here's the .prettierrc file used:
```
{
"printWidth": 100,
"proseWrap": "never",
"trailingComma": "none",
"plugins": ["prettier-plugin-java"]
}
```
bmbroom
approved these changes
Feb 11, 2025
ChrisWakefield
approved these changes
Feb 11, 2025
Member
ChrisWakefield
left a comment
ChrisWakefield
left a comment
There was a problem hiding this comment.
Yes, it's prettier! So, so prettier! Thanks for doing this as a separate merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the result of running prettier on the java files.
I'm preparing some changes to implement the 'panels in R' feature request, and the corresponding pull request will be easier to review if the prettier changes are merged first.
Testing
I ran the GitHub Action to generate the NG-CHM Artifacts (resulting commit here), tag 2.25.0-build-42, and verified:
Did not test GalaxyMapGen.jar
Reference
Below is the .prettierrc file used. If after scanning the java code you don't like something, let me know and I'll try to find different settings. I know we were unhappy with some of the settings used in #527.