Allow build linux client workflow task to build again#10
Open
lexiwitch wants to merge 2 commits intoMBII:masterfrom
Open
Allow build linux client workflow task to build again#10lexiwitch wants to merge 2 commits intoMBII:masterfrom
build linux client workflow task to build again#10lexiwitch wants to merge 2 commits intoMBII:masterfrom
Conversation
Old version is deprecated and was causing build failure
The runner environment of ubuntu is severely neutered and attempting to use the i386 repositories immediately causes dependency hell. This resolves that by relying on the docker ubuntu 20.04 image. In full, the changes are: - Specify container to run in. - Set environment variables `DEBIAN_FRONTEND` and `TZ` Without this change, the package installation process will wait asking for input forever (TZ because there's an indirect dependency on tzdata). - Mount the location of the code (github.workspace) to /data in the container - Alter references to github.workspace to reference the location it is mounted to in the container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update upload-artifact version
Old version is deprecated and was causing build failure
Shift build into container
The runner environment of ubuntu is severely neutered and attempting to use the i386 repositories immediately causes dependency hell. This resolves that by relying on the docker ubuntu 20.04 image.
In full, the changes are:
Arbitrarily chosen to be ubuntu 20.04, which is only one major version bump from the previous version you were building for.
DEBIAN_FRONTENDandTZWithout this change, the package installation process will wait asking for input forever (TZ because there's an indirect dependency on tzdata and it will hang waiting for a locale to be selected).
The result correctly creates build artifacts:
My bad for not opening a pull request here, had to fight with Github a bit for whatever reason!