More defensive #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi |
Owner
|
@dereuromark why do you think comments trigger parse error? There are such comment in test file - it does not trigger any parse error for sure: https://github.com/MAXakaWIZARD/PoParser/blob/master/tests/data/general.po#L20 |
MAXakaWIZARD
force-pushed
the
master
branch
8 times, most recently
from
85bb45e to
100fad3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some PO files contain just a inline
Or something like that.
This should not trigger a complete parse error if possible.
This way it is a bit more resilient.
Does it look good?