Open
Conversation
added 2 commits
March 29, 2026 02:48
메인페이지 퍼블리싱 필요한 아이콘 및 이미지 추가 컴포넌트 분리 ( MainTripCard(Empty, Progress, Planned)) 알림 페이지 네비게이션 연결 내 일정 페이지 네비게이션 연결
Contributor
로고가 16픽셀 여백을 두고 붙어야하는데 떨어진 것으로 보임 |
hyerim03
reviewed
Apr 1, 2026
src/screens/HomeScreen.tsx
Outdated
| </View> | ||
| <ContentContainer className="px-[10px] py-[10px] rounded-xl"> | ||
| <Pressable onPress={handleNavigateToDetail} className="items-center justify-center"> | ||
| {hasNotification ? <NoticeDotIcon width={20} height={20} /> : <NoticeIcon width={20} height={20} />} |
Contributor
There was a problem hiding this comment.
dot을 통째로 아이콘으로 넣었다면 20*20이면 사이즈가 디자인과 달라집니다
Contributor
아이콘 수정 수정 필요할 것 같습니다 |
hyerim03
reviewed
Apr 1, 2026
| <LogoIcon width={38} height={38} /> | ||
| <LogoLetter width={65} height={32} /> | ||
| </View> | ||
| <ContentContainer className="px-[10px] py-[10px] rounded-xl"> |
Contributor
There was a problem hiding this comment.
현재 ContentContainer 내부의 쉐도우는 borderRadius가 8로 잡혀있어 화면 구현 상으로는 알림 밖 컨테이너의 borderRadius 8픽셀로 확인이 됩니다 12픽셀로 보이도록 수정해주세요
src/screens/HomeScreen.tsx
Outdated
| <ScrollView | ||
| horizontal | ||
| showsHorizontalScrollIndicator={false} | ||
| contentContainerStyle={{ paddingHorizontal: 16, paddingVertical: 12, gap: 16 }} |
Contributor
There was a problem hiding this comment.
paddingVertical이 지정되면서 상단 글씨와 내용이 더 멀어진 것 같습니다. 디자인 픽셀에 맞추어 주세요
| <Text className="text-gray text-p font-medium">11:00</Text> | ||
| </View> | ||
| <View className="flex-1"> | ||
| <Text className="text-black text-p1 font-semibold mb-1">아사쿠사 센소지</Text> |
Contributor
chip 수정 필요 |
added 4 commits
April 2, 2026 09:02
로고 여백 수정 점아이콘 수정 일정 아이콘 변경 ContentContainer 8픽셀 12픽셀로 보이도록 수정 상단 글씨 padding값 수정 Chip을 MainRecChip으로 추가 후 수정
메인 페이지 테일윈드 폰트 수정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업내용