👽 Update MelusinePipeline for sklearn compatibility#194
Open
HugoPerrier wants to merge 12 commits intomasterfrom
Open
👽 Update MelusinePipeline for sklearn compatibility#194HugoPerrier wants to merge 12 commits intomasterfrom
HugoPerrier wants to merge 12 commits intomasterfrom
Conversation
…date_sklearn_pipeline # Conflicts: # melusine/pipeline.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python version and environment updates:
pyproject.tomland removed references to Python 3.8 and 3.9 from bothpyproject.tomlandtox.ini. Test environments for Python 3.10 and 3.12 are now specified. [1] [2] [3]Pipeline compatibility and type simplification:
fitmethod and a__sklearn_is_fitted__property toMelusinePipelineinmelusine/pipeline.pyto ensure compatibility with scikit-learn >=1.2, which requires pipelines to be fitted before callingtransform.melusine/pipeline.pyby removing explicit type hints from variable assignments, making the code more concise and compatible with Python 3.10+. [1] [2] [3] [4] [5] [6]Regex and segmentation improvements:
melusine/processors.pyto better handle cases where meta keywords are followed by a newline instead of a colon, increasing robustness in email parsing. [1] [2]Minor bugfixes:
melusine/processors.py({,3}to{0,3}for clarity and correctness).