Skip to content

Improve pipeline 'from_config' method#191

Merged
HugoPerrier merged 7 commits intoMAIF:masterfrom
VandvC:feature/pipeline_from_config
Jan 21, 2025
Merged

Improve pipeline 'from_config' method#191
HugoPerrier merged 7 commits intoMAIF:masterfrom
VandvC:feature/pipeline_from_config

Conversation

@VandvC
Copy link
Contributor

@VandvC VandvC commented Jan 7, 2025

Test plan (required)

Tox ✅
image

Pytest ✅
image

PreCommit ✅
image

Build python package ✅
image

Description

  • Improve the reference to IoMixin and remove depreciated 'SaverMixin'
  • Slight correction of misc. details (doc, docstring...)

Fixes #187

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • test error is raised with correct message error
  • test warning is raised with correct depreciation warning

Test Configuration:
OS: macOS
Python version: 3.8 , 3.10 et 3.11
Melusine version: 3.1.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@HugoPerrier HugoPerrier merged commit fe7918c into MAIF:master Jan 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🥅 améliorer un message de raise + minor updates dans la doc (contributing.md ..)

2 participants