-
Notifications
You must be signed in to change notification settings - Fork 15
Update the collection discovery docs page #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
.../source/technical_tutorials/search/federated-collection-discovery/collection_discovery.ipynb
Show resolved
Hide resolved
.../source/technical_tutorials/search/federated-collection-discovery/collection_discovery.ipynb
Show resolved
Hide resolved
.../source/technical_tutorials/search/federated-collection-discovery/collection_discovery.ipynb
Show resolved
Hide resolved
| @@ -5,30 +5,27 @@ | |||
| "id": "337f5e01-9946-465a-8657-e4153fbac541", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #6. "bbox": ",".join(str(coord) for coord in finland_bbox),
might be nice to print the syntax of a good bbox for people to see as they try to make their own.
Reply via ReviewNB
.../source/technical_tutorials/search/federated-collection-discovery/collection_discovery.ipynb
Show resolved
Hide resolved
.../source/technical_tutorials/search/federated-collection-discovery/collection_discovery.ipynb
Show resolved
Hide resolved
|
I haven't tried all the code yet, just reviewed the text and overall document. |
.../source/technical_tutorials/search/federated-collection-discovery/collection_discovery.ipynb
Show resolved
Hide resolved
.../source/technical_tutorials/search/federated-collection-discovery/collection_discovery.ipynb
Show resolved
Hide resolved
|
@wildintellect thanks for the structural feedback - I added the guide to the web app and moved pystac-client to the top of the API section. |
|
Now we just need someone to have time to test the code ... @HarshiniGirish ? |
|
@hrodmn @wildintellect I’m seeing different behavior between MAAP Hub and MAAP ADE. The same notebook runs on Hub, but on ADE it fails in the collection search cell with AttributeError: 'Client' object has no attribute 'collection_search' |
|
That's probably a |
|
Since the ADE image has pystac-client pinned to 0.6.x you have to upgrade pystac-client to a more recent version to make it work. We can leave it as-is and stick this in the hub branch or I can add a note at the top declaring the version requirement and showing how to install it on the ADE. |

Update the docs to show how to use the collection-search-only STAC API (instead of the custom STAC + CMR API).