Outlier event #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KehanGit
commented
Nov 7, 2023
KehanGit
commented
- Created OutlierEvents class
- Moved class function from_station to BaseEvents because OutlierEvents also needs to use it.
- Tested outlier events with a list of numbers and data from station
added 8 commits
October 30, 2023 09:32
…s with a list of numbers and data from station; 3) moved class function from_station to BaseEvents
micahjohnson150
requested changes
Nov 13, 2023
Contributor
micahjohnson150
left a comment
micahjohnson150
left a comment
There was a problem hiding this comment.
I should have probably thought more about this addition. I hadn't considered an outlier would likely be a singular date and not a time period. Let me know if you have any questions on the comments here. Mostly I think we should add a new time period class for representing a single date/value. Then we use that class to populate the events property for each outlier.
…OutlierEvents only; 3) Tested the date and value
…at of original events. 2. Added in Values and dates property for convenience.
Epoch Modifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.