Skip to content

Conversation

@Ickaser
Copy link
Member

@Ickaser Ickaser commented Jan 1, 2026

This takes just the unit testing scripts, etc. from #6 and makes it into a separate PR.

Ping: @bernalde . I may request your feedback about some of the structure and patterns about these unit tests, but there are some things I know for sure I would like to change about these tests. I intend to merge this before #9 to ensure that I don't break the API in that refactor.

Copy link
Member Author

@Ickaser Ickaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: still need to reorganize tests across files and DRY them out a bit. Some tests are still not passing, and so far that sometimes means the tests are nonsense but in a couple cases means that there was a bug.

@Ickaser
Copy link
Member Author

Ickaser commented Jan 9, 2026

Note to self: some tests are skipped, because they pertain to cases where decisions must still be made (e.g. how to gracefully handle cases where optimization has no feasible solution). All others should be passing now, but opt_Pch_Tsh, opt_Tsh still haven't been reviewed, and in general tests should be reorganized logically across test modules (rather than ..._coverage.py, etc.).

It's annoying to wait for some slow tests to run when doing frequent iteration, but I find that I come down against the "only run slow tests after merge" philosophy. Either logically separate tests so that only the "relevant" ones are run on a PR, or run all of them; at most, let a developer run the "slow" tests separately on their local machine with pytest tests/ -k "not slow". Either way, the list of tests that are "slow" needs to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant