[WIP] [SDL-0250] Next RPC Indication for the HMI#1
Draft
YuriiLokhmatovGitHub wants to merge 9 commits intodevelopfrom
Draft
[WIP] [SDL-0250] Next RPC Indication for the HMI#1YuriiLokhmatovGitHub wants to merge 9 commits intodevelopfrom
YuriiLokhmatovGitHub wants to merge 9 commits intodevelopfrom
Conversation
…o the following 3: [SDLChoiceCell, SDLMenuCell, SDLSoftButtonObject]; implement nextFunctionInfo property in the parent;
YaroslavLutsenko
requested changes
Oct 27, 2021
YaroslavLutsenko
left a comment
There was a problem hiding this comment.
- Please add changes to AddCommand RPC. I think MenuReplaceUtilities (or something like this) has to be updated also.
- Maybe I missed some logic, but I didn't find how SDLSoftButtonObject sets NextFunctionInfo into SDLSoftButton.
Author
Thank you for your feedback. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Things to note: Pull Requests must fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the Contributing Guide for information on branch naming and the CLA, and the SmartDeviceLink GitHub Best Practices document for more information on how to enter a pull request. Please create the PR as a draft until it is ready for review. Once this PR is ready for review, please request one from @smartdevicelink/ios and mark the PR as ready for review.
Also, remember that all new public file headers should be added as public in the
File Inspector / Target Membershippane, placed in theSmartDeviceLink/publicfolder on the file system, and added toSmartDeviceLink.h. Private files should be placed in theSmartDeviceLink/privatefolder.Delete the above section when you've read it.]
Implements #0250
Risk
This PR makes [no / minor / major] API changes.
Testing Plan
Unit Tests
[Describe the unit tests and behaviors added in this PR]
Core Tests
[List of tests performed against Core and behaviors verified]
Core version / branch / commit hash / module tested against: [INSERT]
HMI name / version / branch / commit hash / module tested against: [INSERT]
Summary
[Summary of PR changes]
Changelog
Breaking Changes
Enhancements
Bug Fixes
Tasks Remaining:
CLA