Skip to content

[WIP] [SDL-0250] Next RPC Indication for the HMI#1

Draft
YuriiLokhmatovGitHub wants to merge 9 commits intodevelopfrom
feature/0250_next_func_id
Draft

[WIP] [SDL-0250] Next RPC Indication for the HMI#1
YuriiLokhmatovGitHub wants to merge 9 commits intodevelopfrom
feature/0250_next_func_id

Conversation

@YuriiLokhmatovGitHub
Copy link

@YuriiLokhmatovGitHub YuriiLokhmatovGitHub commented Oct 27, 2021

[Things to note: Pull Requests must fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the Contributing Guide for information on branch naming and the CLA, and the SmartDeviceLink GitHub Best Practices document for more information on how to enter a pull request. Please create the PR as a draft until it is ready for review. Once this PR is ready for review, please request one from @smartdevicelink/ios and mark the PR as ready for review.

Also, remember that all new public file headers should be added as public in the File Inspector / Target Membership pane, placed in the SmartDeviceLink/public folder on the file system, and added to SmartDeviceLink.h. Private files should be placed in the SmartDeviceLink/private folder.

Delete the above section when you've read it.]

Implements #0250

Risk

This PR makes [no / minor / major] API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

[Describe the unit tests and behaviors added in this PR]

Core Tests

[List of tests performed against Core and behaviors verified]

Core version / branch / commit hash / module tested against: [INSERT]
HMI name / version / branch / commit hash / module tested against: [INSERT]

Summary

[Summary of PR changes]

Changelog

Breaking Changes
  • [Breaking change info]
Enhancements
  • [Enhancement info]
Bug Fixes
  • [Bug Fix Info]

Tasks Remaining:

  • [Task 1]
  • [Task 2]

CLA

Copy link

@YaroslavLutsenko YaroslavLutsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add changes to AddCommand RPC. I think MenuReplaceUtilities (or something like this) has to be updated also.
  2. Maybe I missed some logic, but I didn't find how SDLSoftButtonObject sets NextFunctionInfo into SDLSoftButton.

@YuriiLokhmatovGitHub
Copy link
Author

YuriiLokhmatovGitHub commented Oct 28, 2021

  • Please add changes to AddCommand RPC. I think MenuReplaceUtilities (or something like this) has to be updated also.
  • Maybe I missed some logic, but I didn't find how SDLSoftButtonObject sets NextFunctionInfo into SDLSoftButton.
  1. The thing is, there is no mention that AddCommand RPC should be changed on the mobile side but on HMI side only and I am trying to follow the proposal.
  2. SDLSoftButtonObject sets NextFunctionInfo onto a new created SDLSoftButton instance in the method
    - (SDLSoftButton *)currentStateSoftButton {...}
    which is being called in the 2 following operations:
    SDLSoftButtonReplaceOperation and SDLSoftButtonTransitionOperation (pls see SDLSoftButtonObject.m, line 110).

Thank you for your feedback.

@YaroslavLutsenko
Copy link

  • Please add changes to AddCommand RPC. I think MenuReplaceUtilities (or something like this) has to be updated also.
  • Maybe I missed some logic, but I didn't find how SDLSoftButtonObject sets NextFunctionInfo into SDLSoftButton.
1. The thing is, there is no mention that `AddCommand` RPC should be changed on the mobile side but on HMI side only and I am trying to follow the proposal.

2. SDLSoftButtonObject sets NextFunctionInfo onto a new created SDLSoftButton instance in the method  `- (SDLSoftButton *)currentStateSoftButton {...}` which is being called in the 2 following operations: `SDLSoftButtonReplaceOperation` and `SDLSoftButtonTransitionOperation`  _(pls see SDLSoftButtonObject.m, line 110)_.

Thank you for your feedback.

  1. I think this point needs to be deceased on our sync call.
  2. Thanks, I got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants