Core dump on ignition off during registering 20 apps#254
Open
RomanReznichenkoLuxoft wants to merge 5 commits intodevelopfrom
Open
Core dump on ignition off during registering 20 apps#254RomanReznichenkoLuxoft wants to merge 5 commits intodevelopfrom
RomanReznichenkoLuxoft wants to merge 5 commits intodevelopfrom
Conversation
LitvinenkoIra
requested review from
LitvinenkoIra,
OlhaVorobiova and
VladSemenyuk
LitvinenkoIra
changed the title
RomanReznichenkoLuxoft
force-pushed
the
fix/core_dump_on_ignition_off_during_registering_20_apps
branch
from
b6a4138 to
cfe0d5e
Compare
RomanReznichenkoLuxoft
force-pushed
the
fix/core_dump_on_ignition_off_during_registering_20_apps
branch
2 times, most recently
from
3ef0d35 to
d3d8a29
Compare
RomanReznichenkoLuxoft
changed the title
RomanReznichenkoLuxoft
force-pushed
the
fix/core_dump_on_ignition_off_during_registering_20_apps
branch
2 times, most recently
from
dc484f8 to
21fc6d3
Compare
RomanReznichenkoLuxoft
force-pushed
the
fix/core_dump_on_ignition_off_during_registering_20_apps
branch
from
21fc6d3 to
ac51df2
Compare
RomanReznichenkoLuxoft
force-pushed
the
fix/core_dump_on_ignition_off_during_registering_20_apps
branch
4 times, most recently
from
45a87a0 to
f238a42
Compare
RomanReznichenkoLuxoft
force-pushed
the
fix/core_dump_on_ignition_off_during_registering_20_apps
branch
from
f238a42 to
aa44a56
Compare
RomanReznichenkoLuxoft
force-pushed
the
fix/core_dump_on_ignition_off_during_registering_20_apps
branch
4 times, most recently
from
44b3348 to
53a96bc
Compare
RomanReznichenkoLuxoft
force-pushed
the
fix/core_dump_on_ignition_off_during_registering_20_apps
branch
2 times, most recently
from
315c44d to
ed34a73
Compare
…tructor in the application Synchronization of data in threads and controlled deletion in the destructor in the application
RomanReznichenkoLuxoft
force-pushed
the
fix/core_dump_on_ignition_off_during_registering_20_apps
branch
5 times, most recently
from
e88f0f9 to
819a6fd
Compare
RomanReznichenkoLuxoft
force-pushed
the
fix/core_dump_on_ignition_off_during_registering_20_apps
branch
2 times, most recently
from
8d69abc to
88591b1
Compare
…thod to check whether the active HMI in the Commands. Delete a request from a mobile that is processed in RequestControllerImpl.
RomanReznichenkoLuxoft
force-pushed
the
fix/core_dump_on_ignition_off_during_registering_20_apps
branch
from
88591b1 to
70e4d17
Compare
OlhaVorobiova
approved these changes
Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12637
This PR is ready for review.
Risk
This PR makes no API changes.
Summary
SDL core dump on Ignition OFF during registering 20 Apps.
During application registration, the ignition is turned off and the fields of the ApplicationManagerImpl object are deleted. We were unable to delete the fields that are deleted after exiting the destructor. Because we used them in other threads. After that, there was a hang of SDL, because we used two mutexes in different sequences in different places.
Then there was a crash due to the use of non-synchronized data in the objects of the Application.
Fixing this opened a drop in the RequestControllerImpl. The fall was due to the fact that sdl uses smart pointers, and they are copied to different threads. So I added delete mobile of the requests in the threads processing these request.
CLA