Open
Conversation
Check if read only parameters are cut off before sending a message to HMI.
3 tasks
mvorobio
requested review from
AByzhynar,
LitvinenkoIra,
SNiukalov and
ydementieiev
AByzhynar
reviewed
Apr 24, 2020
| auto command = | ||
| CreateRCCommand<rc_rpc_plugin::commands::SetInteriorVehicleDataRequest>( | ||
| mobile_message); | ||
| auto command = CreateRCCommand<SetInteriorVehicleDataRequest>(mobile_message); |
There was a problem hiding this comment.
@mvorobio Is it possible to make it const auto?
ydementieiev
approved these changes
Apr 25, 2020
SNiukalov
approved these changes
Apr 25, 2020
LitvinenkoIra
approved these changes
Apr 27, 2020
AByzhynar
approved these changes
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not ready for review.
Risk
This PR makes no API changes.
Summary
The PR adds a check whether read only parameters are cut off before sending a message to
HMI in unit tests for SetInteriorVehicleDataRequest.
Tasks Remaining:
CLA