Open
Conversation
Collaborator
|
Very nice! This takes a lot less code than I thought it would. The figure size definitely needs some thought. On my 1080p external screen at home everything is enormous, and some figures have the wrong aspect ratio. I'm also finding that I can't import Luna and PyPlot simultaneously--it crashes Julia in all of my attempts. It seems that GLMakie interferes with the PyPlot backend in some horrible way. The CI will need some extra lines to make the import work: https://discourse.julialang.org/t/ci-fails-to-build-glmakie-dependency/80125 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches plotting to Makie.
In this initial state, I think it is complete but it is fairly untested (and also only tested on 1.9.0beta3). There are numerous small issues with the text display, and I haven't worked out how to automatically set the figure resolution and font size. But it works quite well.
The Makie DataInspector is quite nice for getting numbers from the plots, and zooming etc. works if you know the Makie system. Also it is easy to make nice 3d plots, like this new spectrogram version:
Also, it doesn't crash long-running Julia sessions on the mac!