Merged
Conversation
jtravs
approved these changes
Oct 5, 2021
src/Ionisation.jl
Outdated
| *exp(-4/3*ω_p/(ω_t_prefac*abs(E)))) | ||
| if cycle_average | ||
| (avfac*sqrt(abs(E))*ω_p*cn_sq* | ||
| (4*ω_p/(ω_t_prefac*abs(E)))^(2*nstar-1) |
Contributor
There was a problem hiding this comment.
Wouldn't it be nice to factorise the common parts of the two cases? So just the part that changes is inside the conditional?
Collaborator
Author
There was a problem hiding this comment.
Yes--I thought it would slow it down (by adding an extra step) but actually it makes no measurable difference
src/Ionisation.jl
Outdated
| (4*ω_p/(ω_t_prefac*abs(E)))^(2*nstar-1) | ||
| *exp(-4/3*ω_p/(ω_t_prefac*abs(E)))) | ||
| if cycle_average | ||
| (avfac*sqrt(abs(E))*ω_p*cn_sq* |
Contributor
There was a problem hiding this comment.
Do you have a reference for this, or did you just work it out?
Collaborator
Author
There was a problem hiding this comment.
It's from Zenghu Chang's book:
I've added a comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rcyclewith defaulttrue, keyword argument is nowcycle_averagewhich defaults tofalse.