[pull] master from TaterClient:master#16
Open
pull[bot] wants to merge 172 commits intoLuoChu-DDNetDev:masterfrom
Open
[pull] master from TaterClient:master#16pull[bot] wants to merge 172 commits intoLuoChu-DDNetDev:masterfrom
pull[bot] wants to merge 172 commits intoLuoChu-DDNetDev:masterfrom
Conversation
Prevent new config/command flags from being added without also handling them in the HTML table export script.
When disconnecting from a local server, the client immediately requests the server info from LAN servers. This server info is incorrectly considered to be the server info pong, which is only expected to be received when connecting to a server, because `ServerAddress()` still contains the value of the last server that the client connected to. The pong was considered invalid, so it did not enter the `ValidPong` branch below, but it caused `Discord()->UpdateServerInfo` to be called while not online with the previous map name. This will be an issue when the current map name is stored inside the map class and not separately in the client, at which point accessing the map name will crash with an assertion when the map is unloaded.
Datafiles are not strictly maps but generic containers, and the function name prefix `Map` is redundant for `IEngineMap`.
``` /home/runner/work/ddnet/ddnet/src/game/client/components/skins.h:84: warning: unable to resolve link to 'LOADING' for \link command ```
Fixes the workaround we needed for the old doxygen. Gives us full control over the doxygen version Makes the CI less dependent on ubuntu.
All selected items in the editor (e.g. selected group, layers, envelope points etc.) should be tracked separately for each editor map to support using multiple maps at the same time. Move all relevant variables and functions to `CEditorMap`. Group and reorder the functions.
It's not necessary, unless other things like server name change — but that is handled separately.
- Avoid constructing HTML with `innerHTML` for log output lines. - Show fatal errors in bold font. - Hide unnecessary horizontal scrollbar.
Improve readability by not showing the ANSI escape codes in the output. Show the log line colors as a border on the left side of the log messages, as coloring the full log messages makes them unreadable in many cases.
This significantly reduces the number of source files that need to be recompiled when adding/removing font icons, as previously all files depending on `textrender.h` had to be recompiled. Sort the constants in lexicographical order to make it easier to add more, as the grouping and ordering was previously unclear. Use qualified names for all font icons and rename the namespace to `FontIcon`, instead of duplicating the `FONT_ICON_` part in the constant name and mostly using `using namespace FontIcons` in other files.
Handle Emscripten client being quit or aborted in the HTML wrapper by hiding the canvas, instead of doing this in the client only on successful exit. Also reset the canvas' cursor to ensure it becomes visible again. On client quit, print a log output indicating that the client can be restarted by reloading the page. Add button for convenience to reload page. Handle WebGL context lost event by quitting the client and logging an error message. The client cannot currently recover from GL context loss, because it would require reloading all textures, framebuffers etc. Handle WebGL context creation error event by logging a more detailed error message. The client already handles the failed context creation.
Add version to android
As soon as ddnet edits this I will get a inline git conflict from ddnet-insta@dcb7505 which is fiddely. Its nicer to look at conflicts if array elements have their own lines.
force display 0xE0073 as a replacement character
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )