Adding videos samples with different resolutions#18
Draft
animanathome wants to merge 3 commits intomainfrom
Draft
Adding videos samples with different resolutions#18animanathome wants to merge 3 commits intomainfrom
animanathome wants to merge 3 commits intomainfrom
Conversation
|
✅ Linked to Task LU-2813 · Create a version of NodeVideoElement which uses framefusion |
animanathome
commented
Apr 25, 2023
| } | ||
| }); | ||
|
|
||
| it('should get frame dimensions', async() => { |
Contributor
Author
There was a problem hiding this comment.
@antoineMoPa, so this is very surprising since they all pass. Do you know of any sources which didn't match?
Contributor
|
@animanathome I think we can close and remove the branch? In the end that was the "extra pixels on the right" issue. (which made use return image data instead of pixels) |
Contributor
|
@animanathome can we close this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding more test to verify
widthandheight