Skip to content

Allow external links from <see> element with href attribute #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterjp80 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow external links from <see> element with href attribute #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions MarkdownDocNet/DocParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,11 +630,20 @@ public string ParseDocText(XNode node, string contextMemberName)
var element = (XElement)node;
if (element.Name == "see")
{
var descriptor = element.Attribute("cref").Value;
var crefAttribute = element.Attribute("cref");
var hrefAttribute = element.Attribute("href");

var value = crefAttribute == null ? element.Attribute("href").Value : element.Attribute("cref").Value;
var isValueDescriptor = crefAttribute != null;

string linkName = null;
if (!String.IsNullOrEmpty(element.Value))
linkName = element.Value;
return LinkFromDescriptor(descriptor, contextMemberName, linkName);

if (!isValueDescriptor && String.IsNullOrEmpty(linkName))
linkName = value;

return isValueDescriptor ? LinkFromDescriptor(value, contextMemberName, linkName) : Link(value, linkName);
}
else if (element.Name == "code")
{
Expand Down Expand Up @@ -680,6 +689,11 @@ public string LinkFromDescriptor(string descriptor, string contextMemberName, st
return " [" + linkName + "](#" + link + ") ";
}

public string Link(string link, string linkName = null)
{
return " [" + linkName + "](" + link + ") ";
}

public string FullNameFromDescriptor(string descriptor)
{
var descriptorElements = descriptor.Split(':');
Expand Down