Added Background Color #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luehang
requested changes
Dec 23, 2018
Owner
Luehang
left a comment
Luehang
left a comment
There was a problem hiding this comment.
Hi eyalabadi98,
Thanks for contributing.
Can you make the following changes before merging?
Thanks.
| | `images` | An array of objects. `uri` is a required field. EX. `[{uri: "https://luehangs.site/pic-chat-app-images/beautiful-blond-fishnet-stockings-48134.jpg"}, {uri: "https://luehangs.site/pic-chat-app-images/beautiful-blond-blonde-hair-478544.jpg"}]` | `Array` | Required | | ||
| | `columns` | Desired number of columns. | `number` | 2 | | ||
| | `spacing` | Gutter size of the column. The spacing is a multiplier of 1% of the available view. | `number` | 1 | | ||
| | `backgroundColor` | Defined a background color for the viewer | `string` | 2 | |
Owner
There was a problem hiding this comment.
A more descriptive prop name should be used for the MasonryList layout portion. Something like masonryBackgroundColor.
| Contributors will be posted here. | ||
|
|
||
| <br/> | ||
| <br/> Eyal Abadi |
Owner
There was a problem hiding this comment.
A 100x100px circle photo of your choosing should be added to the Contributors section.
Example:
<a href="https://www.facebook.com/lue.hang">
<img src="www.hosting.com/profile-circle-75px.png"/>
</a>
If you want me to host a picture, then I can edit this section. Just send me the picture and your preferred href.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility of adding background color.
The only thing I need your help with is doing a default color, I wasnt sure how to.
-Eyal