Skip to content

Show loading widget at bottom of loading lists #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DouglasValerio wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Show loading widget at bottom of loading lists #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1f5820
Ensure list length in Loading State takes Resource.data into account
May 5, 2022
a4d7204
Add logic to build loading widget at the bottom of a list in the Load…
May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions lib/src/widgets/list_view_resource_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ class ListViewResourceWidget<T> extends StatelessWidget {

switch (resource.status) {
case Status.loading:
lenght += loadingTileQuantity;
lenght += (resource.data ?? []).length + loadingTileQuantity;
break;
case Status.success:
if (emptyWidget != null &&
Expand Down Expand Up @@ -285,10 +285,10 @@ class ListViewResourceWidget<T> extends StatelessWidget {
switch (resource.status) {
case Status.loading:
if (loadingTile != null) {
return loadingTile!;
return _handleLoadingState(index, data, loadingTile!);
}
if (loadingTileBuilder != null) {
return loadingTileBuilder!();
return _handleLoadingState(index, data, loadingTileBuilder!());
}
break;
case Status.success:
Comment on lines 287 to 294
Copy link
Copy Markdown
Owner

@LucazzP LucazzP May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, will not be better to return this _handleLoadingState if is with Status.loading or Status.success?
Because you added the success logic on this function, so the correct name for this function should be _mapIndexToTile, or something like that... What you think?

Expand Down Expand Up @@ -316,6 +316,21 @@ class ListViewResourceWidget<T> extends StatelessWidget {
return const SizedBox.shrink();
}

Widget _handleLoadingState(int index, List<T> data, Widget returnableLoadingWidget) {
final _maxIndexForPopulatedDataArray = data.length - 1;
final _shouldReturnEmptyWidget = emptyWidget != null &&
(resource.data == null || (resource.data ?? []).isEmpty);

if (index > _maxIndexForPopulatedDataArray) return returnableLoadingWidget;
if (_shouldReturnEmptyWidget) return emptyWidget ?? const SizedBox.shrink();

final widget = tileMapper(data[index]);
if (separatorBuilder != null) {
return separatorBuilder!(index, widget);
}
return widget;
}

Widget _proxyDecorator(Widget child, int index, Animation<double> animation) {
return AnimatedBuilder(
animation: animation,
Expand Down