V1.0.0 alpha.11 #86
Draft
V1.0.0 alpha.11 #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indings & swift and Kotlin files
…g for wallet creation and error handling in Kotlin. Updated wallet method signatures in TypeScript to correct parameter order and improve clarity. Adjusted TypeScript and JavaScript files for consistency in class definitions.
… balance properties to use conversion methods for consistent data types (Long or String). Adjusted method call in Wallet class for improved clarity. Added extension function for balance conversion in Kotlin.
… Updated method signature to improve clarity and consistency across TypeScript interfaces. Adjusted implementation in Wallet class to align with new signature.
…ated method signature from walletCommit to commit for improved clarity and consistency across TypeScript interfaces. Adjusted implementation in Wallet class to align with the new signature.
…asses. Updated method signatures from walletCalculateFee and walletCalculateFeeRate to calculateFee and calculateFeeRate for improved clarity and consistency across TypeScript interfaces. Adjusted implementations in Wallet class to align with the new signatures.
…sses. Updated method signature from walletGetTx to getTx for improved clarity and consistency across TypeScript interfaces. Enhanced transaction ID validation in BdkRnModule to ensure correct format before fetching transactions. Adjusted implementations in Wallet class to align with the new signature.
…pdated method signature from walletListOutput to listOutput for improved clarity and consistency across TypeScript interfaces. Enhanced output serialization in BdkRnModule to create a React Native compatible array of outputs, ensuring better integration with React Native components.
…roved clarity and consistency. Updated walletSentAndReceived to sentAndReceived and walletStartFullScan to startFullScan in both TypeScript and JavaScript files. Adjusted implementations accordingly to align with the new signatures.
…roved clarity and consistency. Updated walletRevealNextAddress to walletRevealNextAddress in Kotlin and adjusted method signatures in TypeScript interfaces for getBalance, startSyncWithRevealedSpks, and walletNew. Enhanced error handling and logging in wallet creation process. Ensured consistent parameter ordering across implementations.
… for improved clarity and consistency. Updated keychain handling and response object preparation. Enhanced balance retrieval to use conversion methods for consistent data types. Improved error handling and logging during wallet creation and address revelation processes.
…hod handling and type safety
|
I recommend updating to the latest and greatest bdk-ios and bdk-android 1.1 versions, see: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.