feat: Add RetroAchievements integration and in-game notifications by clintonium-119 · Pull Request #633 · LoveRetro/NextUI

clintonium-119 · 2026-02-03T21:43:46Z

Adds full RetroAchievements support for tg5040/tg5050 platforms with in-game toast notifications for achievements, save states, screenshots, and more.

RetroAchievements Features:

Login via Settings menu with on-screen keyboard
Achievement unlock notifications with badge images
Progress tracking and leaderboard support
Hardcore mode toggle (disables save states/cheats)
Game hash identification with CHD disc image support
Automatic badge caching and async downloading
Rich presence support

In-Game Notification System:

Toast notifications for save/load state operations
Screenshot confirmation notifications
Volume/brightness change indicators
Achievement unlock popups with game badges
Non-blocking async design

Technical:

Integrates rcheevos library (cloned at build time)
Uses libchdr for CD-ROM/CHD image hashing
Async HTTP client for RA API communication
Thread-safe badge cache with memory management
Platform-conditional compilation (tg5040/tg5050 only)

New files:

common/notification.{c,h} - Toast notification system
common/http.{c,h} - Async HTTP client wrapper
common/ra_auth.{c,h} - RA authentication handling
common/ra_badges.{c,h} - Badge download/caching
minarch/ra_integration.{c,h} - Core RA integration
minarch/chd_reader.{c,h} - CHD image support
rcheevos/makefile - rcheevos library build

Adds full RetroAchievements support for tg5040/tg5050 platforms with in-game toast notifications for achievements, save states, screenshots, and more. RetroAchievements Features: - Login via Settings menu with on-screen keyboard - Achievement unlock notifications with badge images - Progress tracking and leaderboard support - Hardcore mode toggle (disables save states/cheats) - Game hash identification with CHD disc image support - Automatic badge caching and async downloading - Rich presence support In-Game Notification System: - Toast notifications for save/load state operations - Screenshot confirmation notifications - Volume/brightness change indicators - Achievement unlock popups with game badges - Non-blocking async design Technical: - Integrates rcheevos library (cloned at build time) - Uses libchdr for CD-ROM/CHD image hashing - Async HTTP client for RA API communication - Thread-safe badge cache with memory management - Platform-conditional compilation (tg5040/tg5050 only) New files: - common/notification.{c,h} - Toast notification system - common/http.{c,h} - Async HTTP client wrapper - common/ra_auth.{c,h} - RA authentication handling - common/ra_badges.{c,h} - Badge download/caching - minarch/ra_integration.{c,h} - Core RA integration - minarch/chd_reader.{c,h} - CHD image support - rcheevos/makefile - rcheevos library build

workspace/all/common/api.c

workspace/all/minarch/makefile

workspace/all/minarch/ra_consoles.h

workspace/all/minarch/ra_integration.c

workspace/desktop/libmsettings/msettings.c

frysee · 2026-02-04T13:24:19Z

Not necessarily caused by your changes, but I just noticed that the framebuffer is not properly cleared after a notification pill was shown:

makefile

frysee · 2026-02-04T14:35:57Z

When RA is turned off in settings, the ingame "Achievements" menu shows a "No game loaded for achievements" message. I think I would prefer either a more fitting message based on CFG_getRAEnable(), or the menu entry being hidden entirely in that case.

frysee · 2026-02-04T14:37:53Z

On initial launch of a game where nothing has been cached yet, I can see major slowdown while the badges are pulled down (my assumption). Maybe a toast should stick around until that background process completes?

Co-authored-by: frysee <frysee@googlemail.com>

clintonium-119 · 2026-02-04T14:40:45Z

When RA is turned off in settings, the ingame "Achievements" menu shows a "No game loaded for achievements" message. I think I would prefer either a more fitting message based on CFG_getRAEnable(), or the menu entry being hidden entirely in that case.

Good catch. I think I should hide it completely in that case.

clintonium-119 · 2026-02-04T14:43:06Z

On initial launch of a game where nothing has been cached yet, I can see major slowdown while the badges are pulled down (my assumption). Maybe a toast should stick around until that background process completes?

Yeah, that's a good idea. I can implement that.

When notifications end, trigger 3 frames of glClear() to fully clear the framebuffer including areas outside the game's viewport.

GFX API refinements: - Remove center_x param from GFX_blitWrappedText (calculates internally) - Rename screen to surface for clarity - Add IndicatorType enum (BRIGHTNESS, VOLUME, COLORTEMP) - Use GFX_blitPillLight instead of GFX_blitPillColor - Use SDL_SWSURFACE instead of 0 in GFX_createScreenFormatSurface RetroAchievements cleanup: - Refactor ra_consoles.h to use lookup table instead of if/strcmp chain - Replace RA_LOG with leveled macros (DEBUG, INFO, WARN, ERROR) mapping to NextUI's native LOG_* functions Video/Desktop fixes: - Add framebuffer clearing for 3 frames when notifications end - Simplify desktop msettings.c with hardcoded defaults

Store RetroAchievements data (muted achievements, badge cache) in SHARED_USERDATA_PATH/.ra instead of per-platform USERDATA_PATH/ra.

Dynamically adjust options menu based on CFG_getRAEnable() state. When RA is disabled, the Achievements item is hidden and Save Changes moves up to fill the gap.

- Add download queue with max 8 concurrent requests to prevent network/disk thrashing that caused gameplay stuttering - Lazy load badge images on-demand instead of during prefetch (only save PNG to disk during prefetch, decode when displayed) - Show persistent "Loading achievement badges..." indicator during download that auto-hides when complete - Fix progress indicator to omit colon when progress string is empty - Remove unused RA_Badges_hasPendingDownloads()

clintonium-119 · 2026-02-05T20:00:44Z

@frysee

Ready for re-review! Here's a summary of the changes since last feedback:

Badge prefetching optimization - The biggest change. Badge downloads now use a rate-limited queue (max 8 concurrent) with lazy loading. During prefetch, we only save PNGs to disk without decoding; images are loaded on-demand when actually displayed. This seems to completely eliminate the gameplay stuttering that occurred when loading games with 100+ achievements. A persistent "Loading achievement badges..." indicator shows while it's progressing.

Framebuffer clearing

Added 3-frame glClear() when notifications end to address the artifact issue you reported. I wasn't able to reproduce the original issue on my end, so I'd be curious if this fixes it for you.

Other changes:

RA data now stored in shared userdata (SHARED_USERDATA_PATH/.ra) instead of per-platform
Achievements menu hidden when RA is disabled
All your API feedback implemented (GFX refinements, IndicatorType enum, leveled logging, ra_consoles lookup table)

frysee · 2026-02-05T20:04:34Z

@frysee

Ready for re-review! Here's a summary of the changes since last feedback:

Badge prefetching optimization - The biggest change. Badge downloads now use a rate-limited queue (max 8 concurrent) with lazy loading. During prefetch, we only save PNGs to disk without decoding; images are loaded on-demand when actually displayed. This seems to completely eliminate the gameplay stuttering that occurred when loading games with 100+ achievements. A persistent "Loading achievement badges..." indicator shows while it's progressing.

Framebuffer clearing

Added 3-frame glClear() when notifications end to address the artifact issue you reported. I wasn't able to reproduce the original issue on my end, so I'd be curious if this fixes it for you.

Other changes:

RA data now stored in shared userdata (SHARED_USERDATA_PATH/.ra) instead of per-platform

Achievements menu hidden when RA is disabled

All your API feedback implemented (GFX refinements, IndicatorType enum, leveled logging, ra_consoles lookup table)

You're quick! I'll check it out in a bit, thanks!

workspace/all/minarch/minarch.c

frysee · 2026-02-05T20:15:54Z

Looks like a few of the review items are still open above. Let me know if you want me to take over some of them!

…clintonium-119/NextUI into feature/retroachievements-notifications

Extract rendering logic into focused helper functions: - render_system_indicator() for hardware indicator (top-right) - render_progress_indicator() for progress pill (top-left) - render_notification_pill() for individual notification rendering - render_notification_stack() for stacked notifications (bottom-left)

Use ifneq filter pattern to combine identical rcheevos/libchdr linking for all RA-enabled platforms, with nested conditional for desktop rpath.

Per PR feedback, HTTP client is only used by minarch (RA integration). Update include paths in ra_auth.c and ra_badges.c accordingly.

Remove duplicate toolchain file generation for tg5040/tg5050. The build container already provides CMAKE_TOOLCHAIN_FILE.

Keep underlying code intact for future use, but hide menu item until feature is ready. Default remains OFF.

Group 7 related notification state variables into NotificationOverlay struct for improved readability per PR feedback.

- Rename PLAT_findFileInDir to findFileInDir (now in utils) - Remove duplicate static version from minarch.c (uses utils version with improved best-match logic) - Change LOG_info to LOG_debug for match logging (debugging info, not user-facing) - Update api.h, utils.h declarations

- Move gl_notification_surface to top with other static variables - Add comment explaining why draw_rounded_rect is separate from GFX_blitPill* functions (different rendering context: RGBA for GL overlay vs theme assets for screen format)

clintonium-119 · 2026-02-05T23:22:30Z

@frysee I'm sure I've missed (or misunderstood) something, but I've addressed what I could. Let me know if there's anything else you'd like to see,

And thanks for the thorough review and feedback. It's a good learning experience for me.

frysee · 2026-02-05T23:55:41Z

@frysee I'm sure I've missed (or misunderstood) something, but I've addressed what I could. Let me know if there's anything else you'd like to see,

And thanks for the thorough review and feedback. It's a good learning experience for me.

Thanks for taking your time and implementing changes! A lot of the things were stylistic choices, so no big deal in the first place.

workspace/all/common/generic_video.c

workspace/all/minarch/libchdr.makefile

frysee

LGTM - lets revert the http.h location change (my bad, sorry) and then we're good to go I think.

frysee · 2026-02-09T12:53:31Z

Not necessarily caused by your changes, but I just noticed that the framebuffer is not properly cleared after a notification pill was shown:

This is fixed!

Move http.c and http.h back to workspace/all/common/ to avoid minarch-relative include paths in common files (ra_auth.c, ra_badges.c).

clintonium-119 · 2026-02-09T13:47:49Z

Changes are in. Ping for re-review.

frysee · 2026-02-09T14:26:15Z

I think this is good to go. I'm going to let 6.8.0 marinate for a bit in case we need bugfixes for rewind, but I guess we could put this out on the nightly repo already.

Prevents the "Loading badges" notification from showing indefinitely when downloads stall due to poor network conditions.

adthing · 2026-02-12T16:04:46Z

workspace/all/rcheevos/makefile

+	@if [ ! -f "src/include/rc_client.h" ]; then \
+		echo "Cloning rcheevos..."; \
+		rm -rf src; \
+		git clone https://github.com/RetroAchievements/rcheevos.git src; \


super minor but is there a reason why we clone the whole repo and then checkout the version rather than do a shallow clone directly to the version?

clintonium-119 force-pushed the feature/retroachievements-notifications branch 4 times, most recently from 9d1d680 to 89784c0 Compare February 3, 2026 22:58

clintonium-119 force-pushed the feature/retroachievements-notifications branch from 89784c0 to 3dc835d Compare February 3, 2026 23:03

clintonium-119 added 2 commits February 3, 2026 18:13

In CI, disable debug symbols to avoid dsymutil memory issues on macOS

c7129b3

Merge branch 'main' into feature/retroachievements-notifications

3eb971a

frysee requested changes Feb 4, 2026

View reviewed changes

frysee reviewed Feb 4, 2026

View reviewed changes

makefile Outdated Show resolved Hide resolved

Update makefile

46573b9

Co-authored-by: frysee <frysee@googlemail.com>

clintonium-119 added 6 commits February 4, 2026 22:13

Merge branch 'main' into feature/retroachievements-notifications

4eea18d

Fix notification artifacts persisting after dismissal

de6c2ab

When notifications end, trigger 3 frames of glClear() to fully clear the framebuffer including areas outside the game's viewport.

Move RA data to shared userdata directory

2bc7602

Store RetroAchievements data (muted achievements, badge cache) in SHARED_USERDATA_PATH/.ra instead of per-platform USERDATA_PATH/ra.

Hide Achievements menu when RetroAchievements disabled

1edbda1

Dynamically adjust options menu based on CFG_getRAEnable() state. When RA is disabled, the Achievements item is hidden and Save Changes moves up to fill the gap.

Merge branch 'main' into feature/retroachievements-notifications

d4c6a7d

clintonium-119 requested a review from frysee February 5, 2026 20:08

frysee reviewed Feb 5, 2026

View reviewed changes

workspace/all/minarch/minarch.c Outdated Show resolved Hide resolved

frysee reviewed Feb 5, 2026

View reviewed changes

workspace/all/minarch/minarch.c Outdated Show resolved Hide resolved

frysee reviewed Feb 5, 2026

View reviewed changes

workspace/all/minarch/minarch.c Outdated Show resolved Hide resolved

clintonium-119 added 10 commits February 5, 2026 16:33

Merge branch 'feature/retroachievements-notifications' of github.com:…

04787b1

…clintonium-119/NextUI into feature/retroachievements-notifications

Consolidate duplicate RA makefile blocks for tg5040/tg5050/desktop

d1b5b74

Use ifneq filter pattern to combine identical rcheevos/libchdr linking for all RA-enabled platforms, with nested conditional for desktop rpath.

Move http.c/http.h from common/ to minarch/

17f0afc

Per PR feedback, HTTP client is only used by minarch (RA integration). Update include paths in ra_auth.c and ra_badges.c accordingly.

Use container-provided toolchain for libchdr cross-compilation

b13e02f

Remove duplicate toolchain file generation for tg5040/tg5050. The build container already provides CMAKE_TOOLCHAIN_FILE.

Move http.c/http.h from common/ to minarch/

faddf04

Hide hardcore mode setting from UI

b160957

Keep underlying code intact for future use, but hide menu item until feature is ready. Default remains OFF.

Refactor notification overlay statics into struct (generic_video.c)

aff5d9b

Group 7 related notification state variables into NotificationOverlay struct for improved readability per PR feedback.

Clean up notification.c per PR feedback

ff6ae66

- Move gl_notification_surface to top with other static variables - Add comment explaining why draw_rounded_rect is separate from GFX_blitPill* functions (different rendering context: RGBA for GL overlay vs theme assets for screen format)

clintonium-119 requested a review from frysee February 5, 2026 23:21

frysee reviewed Feb 9, 2026

View reviewed changes

workspace/all/common/generic_video.c Outdated Show resolved Hide resolved

frysee reviewed Feb 9, 2026

View reviewed changes

workspace/all/minarch/libchdr.makefile Show resolved Hide resolved

frysee requested changes Feb 9, 2026

View reviewed changes

clintonium-119 added 3 commits February 9, 2026 08:33

Merge branch 'main' into feature/retroachievements-notifications

5cbba51

Remove unneeded dirent.h include

5b560ff

Revert "Move http.c/http.h from common/ to minarch/"

882a1f8

Move http.c and http.h back to workspace/all/common/ to avoid minarch-relative include paths in common files (ra_auth.c, ra_badges.c).

clintonium-119 requested a review from frysee February 9, 2026 13:47

frysee previously approved these changes Feb 9, 2026

View reviewed changes

fix(retroachievements): Add 15s timeout to badge loading notification

3510c8b

Prevents the "Loading badges" notification from showing indefinitely when downloads stall due to poor network conditions.

clintonium-119 dismissed frysee’s stale review via 3510c8b February 11, 2026 16:47

clintonium-119 requested a review from frysee February 11, 2026 16:50

frysee approved these changes Feb 12, 2026

View reviewed changes

frysee merged commit 2a31727 into LoveRetro:main Feb 12, 2026
62 checks passed

adthing reviewed Feb 12, 2026

View reviewed changes

Conversation

clintonium-119 commented Feb 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

frysee commented Feb 4, 2026

Uh oh!

Uh oh!

frysee commented Feb 4, 2026

Uh oh!

frysee commented Feb 4, 2026

Uh oh!

clintonium-119 commented Feb 4, 2026

Uh oh!

clintonium-119 commented Feb 4, 2026

Uh oh!

clintonium-119 commented Feb 5, 2026

Uh oh!

frysee commented Feb 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

frysee commented Feb 5, 2026

Uh oh!

clintonium-119 commented Feb 5, 2026

Uh oh!

frysee commented Feb 5, 2026

Uh oh!

Uh oh!

Uh oh!

frysee left a comment

Choose a reason for hiding this comment

Uh oh!

frysee commented Feb 9, 2026

Uh oh!

clintonium-119 commented Feb 9, 2026

Uh oh!

frysee commented Feb 9, 2026

Uh oh!

Uh oh!

adthing Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants