This repository was archived by the owner on Dec 4, 2018. It is now read-only.
Use jQuery class rather than react className for the screen reader link #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I thought this was a thing! Not sure where I got it from (I wrote this code before React). You can't use |
Contributor
Author
|
@callumacrae Can we get a patch release for this when it merges? |
Contributor
|
eslint didn't like that 😦 Babel might be handling the property. I don't know if the second commit is actually required. I was under the impression it was, but if we have a linting rule for it… |
mrcthms
force-pushed
the
bugfix/fix-skip-preview-link
branch
from
a812bf4 to
8aa4747
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it compiles to
<a classname="for-screen-reader">so it breaks visibility.