Skip to content

objects/mine_cart: add Mine Cart control#5323

Merged
lahm86 merged 3 commits intoLostArtefacts:developfrom
lahm86:mine-cart
Apr 6, 2026
Merged

objects/mine_cart: add Mine Cart control#5323
lahm86 merged 3 commits intoLostArtefacts:developfrom
lahm86:mine-cart

Conversation

@lahm86
Copy link
Copy Markdown
Collaborator

@lahm86 lahm86 commented Apr 5, 2026

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change
  • I have added a readme entry about my new feature or OG bug fix, or it is a different change

Description

This adds control for the Mine Cart. I discovered that Lara doesn't take damage from the overhead drill bits while riding the cart, it's actually the static meshes on the wall that she hits (the logic just treats these the same way as beams). However, these meshes have degenerate hitboxes, hence I've added an injection to add a small one to them. This should have no impact on the drills themselves when Lara encounters them on foot.

Ref: LostArtefacts/TRXInjectionTool#242

@lahm86 lahm86 self-assigned this Apr 5, 2026
@lahm86 lahm86 added Feature New functionality TR3 labels Apr 5, 2026
@github-project-automation github-project-automation bot moved this to In review in TRX Dev tracker Apr 5, 2026
@lahm86 lahm86 requested review from a team, aredfan and rr- April 5, 2026 20:30
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

@aredfan
Copy link
Copy Markdown
Collaborator

aredfan commented Apr 6, 2026

Testing (in progress):

  • The moment when Lara reaches the black frame, apply the breaks. The cart seems to be halting mid-air as it falls.

record.txt

OG video
OG.mp4

@lahm86
Copy link
Copy Markdown
Collaborator Author

lahm86 commented Apr 6, 2026

Fixed the braking - I wasn't doing a gradual deceleration when braking, rather immediately applying it as the speed. Note that this breaks the recording, so will need a fresh test.

@aredfan
Copy link
Copy Markdown
Collaborator

aredfan commented Apr 6, 2026

Fixed the braking - I wasn't doing a gradual deceleration when braking, rather immediately applying it as the speed. Note that this breaks the recording, so will need a fresh test.

Thank you @lahm86, the prior issue is fixed.

  • I noticed a possible interpolation issue when the cart is going down a deep slope, recording attached below. This issue doesn't occur when the game is set to 30 fps.

record.txt

@lahm86
Copy link
Copy Markdown
Collaborator Author

lahm86 commented Apr 6, 2026

Thanks, @aredfan. Should hopefully be improved.

@aredfan
Copy link
Copy Markdown
Collaborator

aredfan commented Apr 6, 2026

Thank you @lahm86, the interpolation looks good. 👍

  • I noticed an inconsistency in Lara's death where the mine cart can roll several times in TRX.

record.txt

OG video
OG.mp4

@lahm86
Copy link
Copy Markdown
Collaborator Author

lahm86 commented Apr 6, 2026

OG looks pretty buggy to be fair 😄

This ensures the HUD shows the game object for Lara's current vehicle,
and is updated for TR3 types.
@lahm86
Copy link
Copy Markdown
Collaborator Author

lahm86 commented Apr 6, 2026

Should be fixed, @aredfan. It was a sneaky one, I was testing a frame number instead of an animation number. Thanks for the vigilance as always!

@aredfan
Copy link
Copy Markdown
Collaborator

aredfan commented Apr 6, 2026

Thank you @lahm86, the death animation looks like a match. 👍

  • I noticed a second issue in the same area. The mine cart appears to be dragged forward the moment Lara bumps into the wall. It's better shown in the video below, first part is OG, second part is TRX. I tested both a few times to make sure the outcome is consistent.

record.txt

Video
Video.mp4

lahm86 added 2 commits April 6, 2026 19:58
The mesh used near the drill bits in RX-Tech Mines has a degenerate
hitbox so Lara doesn't take damage if she hits it while on the
mine cart. This adds a small hitbox to ensure it remains marked
as collidable.
@lahm86
Copy link
Copy Markdown
Collaborator Author

lahm86 commented Apr 6, 2026

Fixed!

@lahm86 lahm86 merged commit d779342 into LostArtefacts:develop Apr 6, 2026
3 checks passed
@lahm86 lahm86 deleted the mine-cart branch April 6, 2026 20:35
@github-project-automation github-project-automation bot moved this from In review to Done in TRX Dev tracker Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New functionality TR3

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants