Fix character generator instantiation and destruction#239
Merged
dmchaledev merged 1 commit intomainfrom Dec 28, 2025
Merged
Conversation
Previously, generate_random_potato_info() instantiated a CharacterGenerator scene and immediately freed it for every potato created. This caused unnecessary GC pressure from repeated allocations during frequent spawning. Implement object pooling by caching a single CharacterGenerator instance that is lazily initialized on first use and reused for all subsequent character generation calls. The pooled generator is hidden and added to the scene tree root to ensure it can access its child nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, generate_random_potato_info() instantiated a CharacterGenerator scene and immediately freed it for every potato created. This caused unnecessary GC pressure from repeated allocations during frequent spawning.
Implement object pooling by caching a single CharacterGenerator instance that is lazily initialized on first use and reused for all subsequent character generation calls. The pooled generator is hidden and added to the scene tree root to ensure it can access its child nodes.